gnutls: fix (failing) p11-kit test #34338
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The p11-kit-trust test looks in /usr/lib for pkcs11 modules. As a result it is unnecessarily skipped on sandboxed builds, and fails on unsandboxed builds with a system p11-kit. Replace hard-coded /usr/lib paths with pkg-config.
Motivation for this change
p11-kit-trust test was failing on my unsandboxed build because the system p11-kit-trust module was found instead, and skipped on normal builds because it wasn't looking in p11_kit. pkg-config knows where it is and tests pass in both cases.
Happy to change if there's a better way to search for this library (e.g.,
$buildInputs
or patch in hard-coded path) or it would be better to just force skip the test regardless.This test does not exist (in this form anyway) in gnutls 3.5.
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)