Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dub: 1.6.0 -> 1.7.1 #34326

Merged
merged 1 commit into from Jan 28, 2018
Merged

dub: 1.6.0 -> 1.7.1 #34326

merged 1 commit into from Jan 28, 2018

Conversation

ThomasMader
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member

grahamc commented Jan 27, 2018

@GrahamcOfBorg build dub

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: aarch64-linux

Package ‘dub-1.7.1’ in /var/lib/gc-of-borg/nix-test-rs-3/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-3/pkgs/development/tools/build-managers/dub/default.nix:57 is not supported on ‘aarch64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Full log: https://logs.nix.gsc.io/?key=nixos/nixpkgs.34326

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

Edit source/app.d to start your project.
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/7xhjaf8rfcvkh14yw6shr4982s7ysw2z-dubUnittests-1.7.1
strip is /nix/store/mdyy001q67hiks0g24ra53z7ckm4jfr4-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/7xhjaf8rfcvkh14yw6shr4982s7ysw2z-dubUnittests-1.7.1
checking for references to /tmp/nix-build-dubUnittests-1.7.1.drv-0 in /nix/store/7xhjaf8rfcvkh14yw6shr4982s7ysw2z-dubUnittests-1.7.1...
building path(s) ‘/nix/store/xsswkm0m88i1fa2l3hzc0x311hl97a53-dub-1.7.1’
installing
/nix/store/xsswkm0m88i1fa2l3hzc0x311hl97a53-dub-1.7.1

Full log: https://logs.nix.gsc.io/?key=nixos/nixpkgs.34326

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-darwin

Linking...
Running ./test/subpackage-ref/test
Edit source/app.d to start your project.
installing
post-installation fixup
strip is /nix/store/i1zz228nl3bljcbb83fq0rq7lr7nvv4y-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/np5ykzd3nh6d2iakwrqsc7n09iih9fj6-dubUnittests-1.7.1
building '/nix/store/2rv5g0a0069i6h3cza6cpclpd9kapwqb-dub-1.7.1.drv'...
installing
/nix/store/rr24mdglqdi091xfwknk9b47idk1kyvk-dub-1.7.1

Full log: https://logs.nix.gsc.io/?key=nixos/nixpkgs.34326

@ThomasMader ThomasMader mentioned this pull request Jan 27, 2018
8 tasks
};

postPatch = ''
# TODO Remove with next release which contains https://github.com/dlang/dub/pull/1354
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, it's nicer and easier this way.
Pushed the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants