Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dmd: 2.078.0 -> 2.078.1 #34324

Merged
merged 1 commit into from Jan 27, 2018
Merged

dmd: 2.078.0 -> 2.078.1 #34324

merged 1 commit into from Jan 27, 2018

Conversation

ThomasMader
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@srhb
Copy link
Contributor

srhb commented Jan 27, 2018

Thanks!

@srhb srhb merged commit 5e5cae0 into NixOS:master Jan 27, 2018
@srhb
Copy link
Contributor

srhb commented Jan 27, 2018

I notice that the previous version wasn't backported to stable. Do you know if that's intentional, and if not, should be backport this as well?

@ThomasMader
Copy link
Contributor Author

I think that's intentional. New versions aren't merged into stable. At least that's my impression because none of my packages were ever backported AFAIK.
Such a policy would make sense too because major version changes can break things which is not something you want.
For me it's ok if the version is frozen in 17.09 till the next release.

Btw. normally people who merge a PR trigger a Bot Build to check if everything still works. See #34326 for example.
Are you missing permissions to do so?

@ThomasMader ThomasMader deleted the dmd2.078.1 branch January 27, 2018 20:59
@srhb
Copy link
Contributor

srhb commented Jan 27, 2018 •
edited

Oh, if that's a major version bump I agree that we shouldn't backport without reason.

I do have permissions to use ofborg, but I just built this locally. Thanks for the concern anyway! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ThomasMader @srhb @GrahamcOfBorg