-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
speedometer: init at 2.8 #33627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
speedometer: init at 2.8 #33627
Conversation
Something's up with how the 'speedometer' program is made (the one without the .py extension):
|
Agreed. That happened when I rebased it on top of master, however; it worked perfectly on the installed commit. I'm trying to track it down. |
The script is broken by commit d945b3e... somehow. |
Two wrapper scripts. One of them works:
And one of them doesn't.
As far as I can tell, they're identical, but bash fails out at the |
...wait a second, that's not bash. Why is Python attempting to execute a bash script? |
Okay! I think I've figured it out. In short... Speedometer, upstream, ships with only one meaningful file: speedometer.py, which is what should be packaged as an application. The application is named speedometer. So far, so good, but buildPythonApplication creates two additional files: .speedometer-wrapped and speedometer. The former is a python script wrapping speedometer.py, the latter is a bash script wrapping .speedometer-wrapped. (At least, I'm assuming that's what does it. Something seems to have parsed speedometer.py in a complex way in order to create it, which is worrying.) .speedometer-wrapped runs I don't think name clashes of this sort are uncommon, so probably that commit should be reverted until the bug is fixed. @FRidh, thoughts? |
The
They create a console script even though the file is already marked as to being installed as a script. |
Ah, I see. I'll report it upstream. :) |
@Baughn are you going to fix this PR or wait for a new release? |
Well, I was hoping for a quick fix from the author, but he seems to be AWOL. Not sure what to do now... fork the repo, maybe. |
For in here you could remove the console script line. |
@GrahamcOfBorg build speedometer |
Success on x86_64-linux (full log) Attempted: speedometer Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: speedometer Partial log (click to expand)
|
Motivation for this change
Adds a useful bandwidth monitoring CLI tool.
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)