New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dhcp: 4.3.4 -> 4.3.6 #33620
dhcp: 4.3.4 -> 4.3.6 #33620
Conversation
(this should probably go to staging first.. ) |
4c8af21
to
1ce8eec
Compare
@GrahamcOfBorg build dhcp |
Success on x86_64-linux (full log) Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
On second thought, was the patch applied upstream or why don't we need that anymore? |
Good question, I wish I had been more specific in my commit message back when I originally look at this... I didn't remember at first! :) They moved from ifconfig to ip (from iproute2), rewriting the script quite a bit. The patch fixed "flushing" the interface, the new script uses commands like:
instead of the problematic |
Failure on aarch64-linux (full log) Partial log (click to expand)
|
Oh, awesome, thanks! 👍 |
Failure on x86_64-linux (full log) Partial log (click to expand)
|
@GrahamcOfBorg build dhcp |
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
Failure on x86_64-linux (full log) Partial log (click to expand)
|
Failure on aarch64-linux (full log) Partial log (click to expand)
|
4.3.6-P1 is out: https://kb.isc.org/article/AA-01570/82/DHCP-4.3.6-P1-Release-Notes.html Will bump this shortly... |
1ce8eec
to
b59df6b
Compare
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
Motivation for this change
https://kb.isc.org/article/AA-01518/82/DHCP-4.3.6-Release-Notes.html
Also removes need for a patch.
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)Works well so far, but should probably be carefully reviewed and tested before merged.