Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/udev: fix outdated udev rules for network devices #33617

Merged
merged 1 commit into from Jan 9, 2018
Merged

nixos/udev: fix outdated udev rules for network devices #33617

merged 1 commit into from Jan 9, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jan 8, 2018

Udev changed its internal naming, so this rule file no longer applied correctly.
Therefore some properties such as network driver no longer matched in
systemd-networkd.

After updating we have more properties in systemd-networkd:

$ sudo networkctl status wlp3s0
...
Driver: iwlwifi
...

To prevent this in future, the file is no copied from systemd directly

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
nixos/udev: fix outdated udev rules for network devices
71cce26 
Udev changed its internal naming, so this rule file no longer applied correctly.
Therefore some properties such as network driver no longer matched in
systemd-networkd.

After updating we have more properties in systemd-networkd:

$ sudo networkctl status wlp3s0
...
   Driver: iwlwifi
...

To prevent this in future, the file is no copied from systemd directly
@Mic92 Mic92 added the 9.needs: port to stable A PR needs a backport to the stable release. label Jan 8, 2018
@Mic92 Mic92 merged commit 470f5ef into NixOS:master Jan 9, 2018
@Mic92 Mic92 deleted the udevd branch January 9, 2018 00:24
@Mic92 Mic92 mentioned this pull request Mar 4, 2018
Merged
8 tasks
@Mic92 Mic92 mentioned this pull request Apr 23, 2018
Merged
8 tasks
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
@Centaurioun Centaurioun mentioned this pull request Mar 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @samueldr @GrahamcOfBorg