Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

networkmanager: 1.10.0 -> 1.10.2, update users #33621

Closed
wants to merge 4 commits into from
Closed

networkmanager: 1.10.0 -> 1.10.2, update users #33621

wants to merge 4 commits into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 8, 2018

Motivation for this change

http://cgit.freedesktop.org/NetworkManager/NetworkManager/tree/NEWS?h=1.10.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dtzWill dtzWill changed the base branch from master to staging January 14, 2018 23:06
@dtzWill
Copy link
Member Author

dtzWill commented Jan 18, 2018

Trying to reduce the number of open PR's I have, let's wait on this until there's a motivation for the bump.

@dtzWill dtzWill closed this Jan 18, 2018
@orivej orivej reopened this Jan 19, 2018
@orivej orivej changed the base branch from staging to master January 19, 2018 19:49
@orivej
Copy link
Contributor

orivej commented Jan 19, 2018

The CFLAGS fixes may be forgotten if the update happens in another PR.

The amount of the rebuilt packages allows this to be merged to master.

@dtzWill
Copy link
Member Author

dtzWill commented Jan 28, 2018

@adisbladis committed most of this in 405e53a, other than the update to networkmanagerapplet (which is probably a good idea but seems to not be strictly required). Not sure if independent, hopefully not since that would be silly waste of (minor) effort :).

If not, check PR's please! :3.

Either way, suppose this can be closed now!

@dtzWill dtzWill closed this Jan 28, 2018
@adisbladis
Copy link
Member

@dtzWill Sorry for not checking open PRs :/

Cherry picked networkmanagerapplet in 15aa4fc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orivej orivej orivej approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @orivej @adisbladis @GrahamcOfBorg