python-modules: fix httpbin by adding all the deps #33615
Conversation
| { stdenv, fetchPypi, buildPythonPackage, colorama }: | ||
|
|
||
| buildPythonPackage rec { | ||
| name = "${pname}-${version}"; |
There was a problem hiding this comment.
drop name here and in other expressions
There was a problem hiding this comment.
Oh, that's automatic? Excellent!
There was a problem hiding this comment.
Ping!
EDIT: Ignore this, I didn't notice that I was looking at an outdated diff (?).
|
@FRidh: done, pushed! |
|
any news on this? |
Test no longer needs to be avoided, see: kevin1024/pytest-httpbin#44
Minor cleanup as well.
|
Rebased onto master and re-tested, ping! (cc @FRidh) Since the package (and anything requiring it) currently fails to build, this seems moderately important. And with a low bar to clear in terms of functionality :P. |
| { stdenv, fetchPypi, buildPythonPackage, colorama }: | ||
|
|
||
| buildPythonPackage rec { | ||
| name = "${pname}-${version}"; |
There was a problem hiding this comment.
Ping!
EDIT: Ignore this, I didn't notice that I was looking at an outdated diff (?).
| flask-compress = callPackage ../development/python-modules/flask-compress { }; | ||
|
|
||
| flask-cors = callPackage ../development/python-modules/flask-cors { }; | ||
|
|
||
| flask_elastic = callPackage ../development/python-modules/flask-elastic { }; | ||
|
|
||
| flask_limiter = callPackage ../development/python-modules/flask-limiter { }; |
There was a problem hiding this comment.
Since the canonical PyPI names of the new packages are Flask-Common and Flask-Limiter, and the manual says not to convert hyphens to underscores (https://nixos.org/nixpkgs/manual/#sec-package-naming), could you use hyphenated names?
There was a problem hiding this comment.
Actually, in python-packages.nix we do not follow those guidelines, but instead stick to the canonical PyPI names, or the normalized names (https://www.python.org/dev/peps/pep-0503/#normalized-names)
There was a problem hiding this comment.
At least, that's what I am pushing for.
| doCheck = false; | ||
|
|
||
| meta = with stdenv.lib; { | ||
| description = "Official timezone database for Python"; |
There was a problem hiding this comment.
This is the description on its website, but I do not see anything official about it. Could you change it to "Timezone database for Python"?
It is quite unfortunate that it ships an outdated version of tzdata rather than using system tzdata, but this is out of scope of this PR.
|
I've included the changes in #34077. |
Motivation for this change
Fixes #33604 .
Fixes httpbin build failure.
Introduces number of new packages that are required by httpbin as of 0.6.2.
httpbin should not have been updated without testing that it builds....
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)