Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libsigcxx: removed patch that forced -std=c++11 in pkg-config file #33623

Merged
merged 1 commit into from Jan 8, 2018
Merged

libsigcxx: removed patch that forced -std=c++11 in pkg-config file #33623

merged 1 commit into from Jan 8, 2018

Conversation

jeroendehaas
Copy link
Contributor

@jeroendehaas jeroendehaas commented Jan 8, 2018 •
edited

This pull request aims to resolve issue #33534 where a left over patch from 2015 caused projects that use libsigc++ via pkg-config to be built according to C++11.

Motivation for this change

This pull requests removed a patch from the derivation for libsigc++-2.0 that is no longer needed and may have unexpected effects when using libsigc++ in a project via pkg-config.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jeroendehaas
libsigcxx: removed patch that forced -std=c++11 in pkg-config file
157332d 
This commit removes a patch from the derivation for libsigc++-2.0 that
appended -std=c++11 to the pkg-config file.

The patch in question orginated from the Debian project to enforce
-std=c++11 in projects using libsigc++-2.0 via pkg-config. This patch
was removed in 2016 when Debian switched to GCC 6.

This fixes #33534.
@vcunat vcunat self-assigned this Jan 8, 2018
vcunat
vcunat approved these changes Jan 8, 2018
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverse dependencies build OK.

@vcunat vcunat merged commit 157332d into NixOS:master Jan 8, 2018
vcunat added a commit that referenced this pull request Jan 8, 2018
@vcunat
Merge #33623: libsigcxx: remove patch forcing -std=c++11
9297a84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees

@vcunat vcunat

Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jeroendehaas @vcunat @GrahamcOfBorg @Janik-Haag