pythonPackages.rx: init at 1.6.0 #33626
Merged
+25
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRidh
requested changes
Jan 10, 2018
|
|
||
| buildPythonPackage rec { | ||
| pname = "rxpy"; | ||
| name = "${pname}-${version}"; |
There was a problem hiding this comment.
name has been removed
| name = "${pname}-${version}"; | ||
| version = "1.6.0"; | ||
|
|
||
| src = fetchFromGitHub { |
There was a problem hiding this comment.
Yes, Though for future is there some preferred order of sources?
There was a problem hiding this comment.
Just changed it to pypi. There are no tests with that source.
thanegill
changed the title
|
Changed the name to match pypi (rxpy -> rx) |
FRidh
reviewed
Jan 10, 2018
|
|
||
| buildPythonPackage rec { | ||
| pname = "rx"; | ||
| name = "${pname}-${version}"; |
|
ping @FRidh |
|
@thanegill this needs rebasing. Ping me again when done. |
|
@FRidh Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)