Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.rx: init at 1.6.0 #33626

Merged
merged 1 commit into from Jan 24, 2018
Merged

pythonPackages.rx: init at 1.6.0 #33626

merged 1 commit into from Jan 24, 2018

Conversation

thanegill
Copy link
Contributor

@thanegill thanegill commented Jan 8, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@thanegill thanegill requested a review from FRidh as a code owner January 8, 2018 19:39
FRidh
FRidh requested changes Jan 10, 2018
View reviewed changes
pkgs/development/python-modules/rxpy/default.nix Outdated

buildPythonPackage rec {
pname = "rxpy";
name = "${pname}-${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name has been removed

pkgs/development/python-modules/rxpy/default.nix Outdated
name = "${pname}-${version}";
version = "1.6.0";

src = fetchFromGitHub {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't we use pypi?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, Though for future is there some preferred order of sources?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just changed it to pypi. There are no tests with that source.

@thanegill thanegill changed the title pythonPackages.rxpy: init at 1.6.0 pythonPackages.rx: init at 1.6.0 Jan 10, 2018
@thanegill
Copy link
Contributor Author

Changed the name to match pypi (rxpy -> rx)

FRidh
FRidh reviewed Jan 10, 2018
View reviewed changes
pkgs/development/python-modules/rx/default.nix Outdated

buildPythonPackage rec {
pname = "rx";
name = "${pname}-${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed name.

@thanegill
Copy link
Contributor Author

ping @FRidh

@FRidh
Copy link
Member

FRidh commented Jan 23, 2018

@thanegill this needs rebasing. Ping me again when done.

@thanegill
Copy link
Contributor Author

@FRidh Rebased.

@FRidh FRidh merged commit 25e3e2d into NixOS:master Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thanegill @FRidh @GrahamcOfBorg