Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore dnscrypt-proxy #33629

Merged
merged 3 commits into from Jan 9, 2018
Merged

Restore dnscrypt-proxy #33629

merged 3 commits into from Jan 9, 2018

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Jan 8, 2018 •
edited

Motivation for this change

See #33540

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Fix test nixos/dnscrypt-proxy.nix
  • Tested compilation of all pkgs that depend on this change using (none)
  • Tested execution of all binary files (dnscrypt-proxy seems to be proxying DNS correctly )
  • Fits CONTRIBUTING.md.

@rnhmjoj
Revert "nixos/dnscrypt-proxy: remove"
4ebb962 
This reverts commit 5dc2853.
The project has a new maintainer.
@joachifm
Copy link
Contributor

joachifm commented Jan 9, 2018

Looks good to me. Is it ready?

@rnhmjoj rnhmjoj changed the title Restore dnscrypt-proxy [WIP] Restore dnscrypt-proxy Jan 9, 2018
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Jan 9, 2018

Should be ready.

@joachifm joachifm merged commit a6912f5 into NixOS:master Jan 9, 2018
@joachifm
Copy link
Contributor

joachifm commented Jan 9, 2018

Thanks

@Profpatsch Profpatsch mentioned this pull request Jan 10, 2018
Closed
@rnhmjoj rnhmjoj deleted the dnscrypt-proxy branch January 22, 2018 19:05
@Centaurioun Centaurioun mentioned this pull request Mar 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rnhmjoj @joachifm @GrahamcOfBorg