Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipvsadm: init at 1.29 #34235

Merged
merged 1 commit into from Jan 28, 2018
Merged

ipvsadm: init at 1.29 #34235

merged 1 commit into from Jan 28, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 24, 2018

Request.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Fixes #34226.

The binaries "run", man pages work...
I think a custom kernel with proper support enabled
is required to actually confirm functionality.

@disassembler
Copy link
Member

@GrahamcOfBorg build ipvsadm

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

gzipping man pages under /nix/store/3d3wlz7ga0mzhll2dw3fvk22ga16k0ih-ipvsadm-1.29/share/man/
strip is /nix/store/mdyy001q67hiks0g24ra53z7ckm4jfr4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/3d3wlz7ga0mzhll2dw3fvk22ga16k0ih-ipvsadm-1.29/sbin 
patching script interpreter paths in /nix/store/3d3wlz7ga0mzhll2dw3fvk22ga16k0ih-ipvsadm-1.29
/nix/store/3d3wlz7ga0mzhll2dw3fvk22ga16k0ih-ipvsadm-1.29/sbin/ipvsadm-save: interpreter directive changed from "/bin/bash" to "/nix/store/i0ay05pqkbnvpfijm52mmlrp6kmkl80c-bash-4.4-p12/bin/bash"
/nix/store/3d3wlz7ga0mzhll2dw3fvk22ga16k0ih-ipvsadm-1.29/sbin/ipvsadm-restore: interpreter directive changed from "/bin/bash" to "/nix/store/i0ay05pqkbnvpfijm52mmlrp6kmkl80c-bash-4.4-p12/bin/bash"
/nix/store/3d3wlz7ga0mzhll2dw3fvk22ga16k0ih-ipvsadm-1.29/etc/rc.d/init.d/ipvsadm: interpreter directive changed from "/bin/sh" to "/nix/store/i0ay05pqkbnvpfijm52mmlrp6kmkl80c-bash-4.4-p12/bin/sh"
checking for references to /tmp/nix-build-ipvsadm-1.29.drv-0 in /nix/store/3d3wlz7ga0mzhll2dw3fvk22ga16k0ih-ipvsadm-1.29...
moving /nix/store/3d3wlz7ga0mzhll2dw3fvk22ga16k0ih-ipvsadm-1.29/sbin/* to /nix/store/3d3wlz7ga0mzhll2dw3fvk22ga16k0ih-ipvsadm-1.29/bin
/nix/store/3d3wlz7ga0mzhll2dw3fvk22ga16k0ih-ipvsadm-1.29

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

Package ‘ipvsadm-1.29’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/pkgs/os-specific/linux/ipvsadm/default.nix:32 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: aarch64-linux

gzipping man pages under /nix/store/dayzpn1dysacmaw444inn8z1vbzlq0xs-ipvsadm-1.29/share/man/
strip is /nix/store/jwz859pxqj7sl2dbwvmxkx68jp774izb-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/dayzpn1dysacmaw444inn8z1vbzlq0xs-ipvsadm-1.29/sbin
patching script interpreter paths in /nix/store/dayzpn1dysacmaw444inn8z1vbzlq0xs-ipvsadm-1.29
/nix/store/dayzpn1dysacmaw444inn8z1vbzlq0xs-ipvsadm-1.29/etc/rc.d/init.d/ipvsadm: interpreter directive changed from "/bin/sh" to "/nix/store/rc78viijga8i0m4imrnqk8d1csyqr8yx-bash-4.4-p12/bin/sh"
/nix/store/dayzpn1dysacmaw444inn8z1vbzlq0xs-ipvsadm-1.29/sbin/ipvsadm-save: interpreter directive changed from "/bin/bash" to "/nix/store/rc78viijga8i0m4imrnqk8d1csyqr8yx-bash-4.4-p12/bin/bash"
/nix/store/dayzpn1dysacmaw444inn8z1vbzlq0xs-ipvsadm-1.29/sbin/ipvsadm-restore: interpreter directive changed from "/bin/bash" to "/nix/store/rc78viijga8i0m4imrnqk8d1csyqr8yx-bash-4.4-p12/bin/bash"
checking for references to /build in /nix/store/dayzpn1dysacmaw444inn8z1vbzlq0xs-ipvsadm-1.29...
moving /nix/store/dayzpn1dysacmaw444inn8z1vbzlq0xs-ipvsadm-1.29/sbin/* to /nix/store/dayzpn1dysacmaw444inn8z1vbzlq0xs-ipvsadm-1.29/bin
/nix/store/dayzpn1dysacmaw444inn8z1vbzlq0xs-ipvsadm-1.29

@dtzWill
Copy link
Member Author

dtzWill commented Jan 28, 2018

from the issue that spawned this PR:

@dtzWill This works great and should be merged. It told me something unexpected, but that's good.

@fpletz fpletz merged commit 4bb42d0 into NixOS:master Jan 28, 2018
@dtzWill dtzWill deleted the feature/ipvsadm branch February 20, 2018 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants