Pyrseas: init at 0.8.0 #34225
Merged
Pyrseas: init at 0.8.0 #34225
+47
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pyrseas is a declarative tool for managing PostgreSQL schemas.
FRidh
requested changes
Jan 24, 2018
| @@ -0,0 +1,43 @@ | |||
| { stdenv, python27Packages, fetchFromGitHub }: | |||
There was a problem hiding this comment.
Don't use python27Packages. If it works with both 2 and 3, then use pythonPackages. If it only works with 2, then python2Packages. We don't support < 2.7 anymore.
| @@ -0,0 +1,43 @@ | |||
| { stdenv, python27Packages, fetchFromGitHub }: | |||
|
|
|||
| let | |||
There was a problem hiding this comment.
how about using a with pythonPackages on the top? It would remove a lot of noise.
|
|
||
| let | ||
| pgdbconn = python27Packages.buildPythonPackage rec { | ||
| name = "pgdbconn-${version}"; |
There was a problem hiding this comment.
pname and version instead of name
| rev = "26c1490e4f32e4b5b925e5b82014ad106ba5b057"; | ||
| sha256 = "09r4idk5kmqi3yig7ip61r6js8blnmac5n4q32cdcbp1rcwzdn6z"; | ||
| }; | ||
| doCheck = false; |
There was a problem hiding this comment.
can you include a comment explaining why the tests are disabled
| }; | ||
| in | ||
|
|
||
| python27Packages.buildPythonPackage rec { |
There was a problem hiding this comment.
This is an application, so buildPythonApplication
| in | ||
|
|
||
| python27Packages.buildPythonPackage rec { | ||
| name = "pyrseas-${version}"; |
| rev = "2e9be763e61168cf20d28bd69010dc5875bd7b97"; | ||
| sha256 = "1h9vahplqh0rzqjsdq64qqar6hj1bpbc6nl1pqwwgca56385br8r"; | ||
| }; | ||
| doCheck = false; |
jtojnar
reviewed
Jan 24, 2018
| }; | ||
| in | ||
|
|
||
| python2Packages.buildPythonPackage rec { |
There was a problem hiding this comment.
Does not it work with python 3? Python 2.7 or higher is listed in the README.
|
@GrahamcOfBorg build pyrseas |
There was a problem hiding this comment.
Success on x86_64-linux (full log)
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/hj7byq7fhnv4a38zsdi5zrn2xwddmp3c-pyrseas-0.8.0
strip is /nix/store/mdyy001q67hiks0g24ra53z7ckm4jfr4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/hj7byq7fhnv4a38zsdi5zrn2xwddmp3c-pyrseas-0.8.0/lib /nix/store/hj7byq7fhnv4a38zsdi5zrn2xwddmp3c-pyrseas-0.8.0/bin
patching script interpreter paths in /nix/store/hj7byq7fhnv4a38zsdi5zrn2xwddmp3c-pyrseas-0.8.0
checking for references to /tmp/nix-build-pyrseas-0.8.0.drv-0 in /nix/store/hj7byq7fhnv4a38zsdi5zrn2xwddmp3c-pyrseas-0.8.0...
wrapping `/nix/store/hj7byq7fhnv4a38zsdi5zrn2xwddmp3c-pyrseas-0.8.0/bin/dbaugment'...
wrapping `/nix/store/hj7byq7fhnv4a38zsdi5zrn2xwddmp3c-pyrseas-0.8.0/bin/dbtoyaml'...
wrapping `/nix/store/hj7byq7fhnv4a38zsdi5zrn2xwddmp3c-pyrseas-0.8.0/bin/yamltodb'...
/nix/store/hj7byq7fhnv4a38zsdi5zrn2xwddmp3c-pyrseas-0.8.0
There was a problem hiding this comment.
Success on aarch64-linux (full log)
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/1y5agz75k2hrv6wligbmpdhfazfhpdkr-pyrseas-0.8.0
strip is /nix/store/jwz859pxqj7sl2dbwvmxkx68jp774izb-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/1y5agz75k2hrv6wligbmpdhfazfhpdkr-pyrseas-0.8.0/lib /nix/store/1y5agz75k2hrv6wligbmpdhfazfhpdkr-pyrseas-0.8.0/bin
patching script interpreter paths in /nix/store/1y5agz75k2hrv6wligbmpdhfazfhpdkr-pyrseas-0.8.0
checking for references to /build in /nix/store/1y5agz75k2hrv6wligbmpdhfazfhpdkr-pyrseas-0.8.0...
wrapping `/nix/store/1y5agz75k2hrv6wligbmpdhfazfhpdkr-pyrseas-0.8.0/bin/dbaugment'...
wrapping `/nix/store/1y5agz75k2hrv6wligbmpdhfazfhpdkr-pyrseas-0.8.0/bin/yamltodb'...
wrapping `/nix/store/1y5agz75k2hrv6wligbmpdhfazfhpdkr-pyrseas-0.8.0/bin/dbtoyaml'...
/nix/store/1y5agz75k2hrv6wligbmpdhfazfhpdkr-pyrseas-0.8.0
There was a problem hiding this comment.
Success on x86_64-darwin (full log)
Partial log (click to expand)
Successfully installed Pyrseas-0.8.0
/private/tmp/nix-build-pyrseas-0.8.0.drv-0/source
post-installation fixup
strip is /nix/store/i1zz228nl3bljcbb83fq0rq7lr7nvv4y-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/bia63icr92q8m7bf6kqy2q2j3ydyjdkj-pyrseas-0.8.0/lib /nix/store/bia63icr92q8m7bf6kqy2q2j3ydyjdkj-pyrseas-0.8.0/bin
patching script interpreter paths in /nix/store/bia63icr92q8m7bf6kqy2q2j3ydyjdkj-pyrseas-0.8.0
wrapping `/nix/store/bia63icr92q8m7bf6kqy2q2j3ydyjdkj-pyrseas-0.8.0/bin/dbaugment'...
wrapping `/nix/store/bia63icr92q8m7bf6kqy2q2j3ydyjdkj-pyrseas-0.8.0/bin/dbtoyaml'...
wrapping `/nix/store/bia63icr92q8m7bf6kqy2q2j3ydyjdkj-pyrseas-0.8.0/bin/yamltodb'...
/nix/store/bia63icr92q8m7bf6kqy2q2j3ydyjdkj-pyrseas-0.8.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pyrseas is a declarative tool for managing PostgreSQL schemas.
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)