Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carnix: 0.5.0 -> 0.6.0 #34238

Merged
merged 1 commit into from Jan 26, 2018
Merged

Carnix: 0.5.0 -> 0.6.0 #34238

merged 1 commit into from Jan 26, 2018

Conversation

P-E-Meunier
Copy link
Contributor

@P-E-Meunier P-E-Meunier commented Jan 24, 2018 •
edited

Motivation for this change

This new version fixes bugs with the "log" crate, and compiles the include field of Cargo.toml as filterSource.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Jan 24, 2018

merge conflict...

@Mic92
Copy link
Member

Mic92 commented Jan 24, 2018

we already had 0.5.2: #33514

@P-E-Meunier P-E-Meunier changed the title Carnix: 0.5.0 -> 0.5.3 Carnix: 0.5.0 -> 0.6.0 Jan 25, 2018
@P-E-Meunier
Copy link
Contributor Author

Fixed, sorry about that.

Mic92
Mic92 reviewed Jan 26, 2018
View reviewed changes
pkgs/top-level/all-packages.nix
let carnix = callPackage ../build-support/rust/carnix.nix { };
carnixFeatures = carnix.carnix_0_6_0_features {};
in
carnix.carnix_0_6_0 carnixFeatures;
Copy link
Member

@Mic92 Mic92 Jan 26, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be a nice feature to have an alias for the latest version of the crate, that is build in the Cargo.toml. Then there would be no need to always update all-packages.nix.

@Mic92 Mic92 merged commit 6fbaa05 into NixOS:master Jan 26, 2018
@P-E-Meunier
Copy link
Contributor Author

I agree it would be cool to have an alias for all top-level crates. Let's see what can be done for the next release.

@P-E-Meunier
Copy link
Contributor Author

Btw, thanks for merging!

@ghost
Copy link

ghost commented Feb 3, 2018

Empty derivation:

$ tree (nix-build -A carnix)
/nix/store/wfm73abpi1r8pi74f6l4xnnybq3wvzaa-rust_carnix-0.6.0
└── lib
    └── link

1 directory, 1 file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@P-E-Meunier @Mic92 @GrahamcOfBorg