python37: init at 3.7.0b1 #34231
Closed
python37: init at 3.7.0b1 #34231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Finally we can remove many encoding work-arounds in Also great for my own projects and sanity. |
lsix
reviewed
Jan 25, 2018
|
|
||
| postPatch = '' | ||
| # Determinism | ||
| substituteInPlace "Lib/py_compile.py" --replace "source_stats['mtime']" "(1 if 'DETERMINISTIC_BUILD' in os.environ else source_stats['mtime'])" |
There was a problem hiding this comment.
I did not go through pep-0552 intensively, but could not use the fact that it offers the possibility to have timestamp-less .pyc files and replace this hack?
something like:
substituteInPlace "Lib/py_compile.py" --replace "invalidation_mode=PycInvalidationMode.TIMESTAMP):" "invalidation_mode=PycInvalidationMode.CHECKED_HASH):"and remove DETERMINISTIC_BUILD env var ? (this wold require some testing…)
There was a problem hiding this comment.
yep, that's on the todo list. We will need to modify some of this patching.
There was a problem hiding this comment.
substituteInPlace "Lib/py_compile.py" --replace "invalidation_mode=PycInvalidationMode.TIMESTAMP):" "invalidation_mode=(PycInvalidationMode.CHECKED_HASH if 'DETERMINISTIC_BUILD' in os.environ else PycInvalidationMode.TIMESTAMP)):"would probably be better
|
Success on x86_64-linux (full log) Attempted: python37 Partial log (click to expand)
|
|
Failure on x86_64-darwin (full log) Attempted: python37 Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: python37 Partial log (click to expand)
|
|
Would not this still need |
https://docs.python.org/3.7/whatsnew/3.7.html#pep-540-forced-utf-8-runtime-mode
So, yes. While your workstation typically has a UTF locale configured, this is or may not be the case on say servers or inside services (using |
Beta version of Python 3.7.
|
Failure on x86_64-darwin (full log) Attempted: python37 Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: python37 Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: python37 Partial log (click to expand)
|
|
Yep, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beta version of Python 3.7.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)The current version builds and works. Even though, we should: