tewisay: init at git-2017-04-14 #33457
Conversation
There was a problem hiding this comment.
Welcome to the Nix packaging!
I will try to help you in this process.
- Squash your commits (no merge commit in your PR)
- The format of a package which comes from a commit is
package-name-YYYY-MM-DD. See https://nixos.org/nixpkgs/manual/#sec-package-naming - Set the licence of the package you are adding.
pkgs/tools/misc/tewisay/default.nix
Outdated
| @@ -0,0 +1,20 @@ | |||
| { stdenv, buildGoPackage, fetchgit, asciidoc, go-runewidth, pflag }: | |||
There was a problem hiding this comment.
Your package fails to build.
You have to specify Go dependencies by using the goDeps attributes. See https://nixos.org/nixpkgs/manual/#ex-buildGoPackage-3
These dependencies can be generated by some tools such as go2nix.
| description = "Provides functions to get fixed width of the character or string"; | ||
| homepage = https://github.com/mattn/go-runewidth; | ||
| platforms = stdenv.lib.platforms.all; | ||
| maintainers = [ stdenv.lib.maintainers.rob ]; |
There was a problem hiding this comment.
I wasn't sure if I could change that. Do I have to add my name to stdenv.lib.maintainers or can I just add it there?
Edit: Got it, was easier than I thought.
pkgs/top-level/all-packages.nix
Outdated
| @@ -2412,6 +2412,8 @@ with pkgs; | |||
|
|
|||
| go-mtpfs = callPackage ../tools/filesystems/go-mtpfs { }; | |||
|
|
|||
| go-runewidth = callPackage ../development/tools/go-runewidth { }; | |||
pkgs/top-level/all-packages.nix
Outdated
| @@ -4024,6 +4026,8 @@ with pkgs; | |||
|
|
|||
| pfstools = callPackage ../tools/graphics/pfstools { }; | |||
|
|
|||
| pflag = callPackage ../development/tools/pflag { }; | |||
There was a problem hiding this comment.
Useless since this is a go dependency.
Chiiruno
changed the title
|
I'm going to close this and then reopen with a new fork, I'm having a hard time with squashing and rebasing. |
Motivation for this change
I like cowsay, so I wanted to add a fun alternative to this repository.
I'm very new to this, so if I'm not following protocol correctly, please just tell me what to do.
Making a nixpkg is a tad confusing to a beginner.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)