Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocaml-modules/dtoa: disable hardening (strictoverflow) on darwin #33443

Merged
merged 3 commits into from Jan 6, 2018
Merged

ocaml-modules/dtoa: disable hardening (strictoverflow) on darwin #33443

merged 3 commits into from Jan 6, 2018

Conversation

eqyiel
Copy link
Contributor

@eqyiel eqyiel commented Jan 5, 2018

Motivation for this change

This prevents a compile-time error on macOS:

clang-4.0: error: argument unused during compilation: '-fno-strict-overflow' [-Werror,-Wunused-command-line-argument]
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/) (by building and running flow, which this is a dependency of)
  • Fits CONTRIBUTING.md.

@eqyiel
ocaml-modules/dtoa: disable hardening (strictoverflow) on darwin
3bd5094 
This prevents a compile-time error on macOS:

clang-4.0: error: argument unused during compilation: '-fno-strict-overflow'
  [-Werror,-Wunused-command-line-argument]
@vbgl
Copy link
Contributor

vbgl commented Jan 5, 2018

Thanks. While you are cleaning the dtoa derivation, may you also:

  • drop the createFindlibDestdir attribute which is not used;
  • drop ounit from the build inputs or enable the tests (checkPhase = "jbuilder runtest").

@eqyiel
Copy link
Contributor Author

eqyiel commented Jan 6, 2018

@vbgl thanks for reviewing 😄

@vbgl vbgl merged commit 8c859b4 into NixOS:master Jan 6, 2018
@eqyiel eqyiel deleted the dtoa-disable-hardening branch November 3, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eqyiel @vbgl @GrahamcOfBorg