Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

newsboat: init at 2.10.2 #33455

Merged
merged 1 commit into from Jan 5, 2018
Merged

newsboat: init at 2.10.2 #33455

merged 1 commit into from Jan 5, 2018

Conversation

dotlambda
Copy link
Member

Motivation for this change

Newsboat is a fork of Newsbeuter, which is unmaintained.

I have no way to test on Darwin. So I just copied the lines from Newsbeuter's default.nix.
It would be nice if someone could test this.

There is also #31719, but that PR seems to be stuck.
Also, I was able to build the docs using the proper docbook packages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

cc @lovek323 @joachifm @tasmo

joachifm
joachifm reviewed Jan 5, 2018
View reviewed changes
pkgs/applications/networking/feedreaders/newsboat/default.nix Outdated

buildInputs
= [ stfl sqlite curl gettext pkgconfig libxml2 json_c ncurses ]
++ stdenv.lib.optional stdenv.isDarwin makeWrapper;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makeWrapper and pkgconfig can be treated as native

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@joachifm
Copy link
Contributor

joachifm commented Jan 5, 2018

LGTM

@joachifm joachifm merged commit a8d7485 into NixOS:master Jan 5, 2018
@dotlambda dotlambda deleted the newsboat branch January 7, 2018 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joachifm joachifm joachifm left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dotlambda @joachifm @GrahamcOfBorg