qtpass: 1.1.6 -> 1.2.1 #33445
Closed
qtpass: 1.1.6 -> 1.2.1 #33445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the avoidance of doubt, this is not a vulnerability in pass(1), the password manager I maintain, but rather in a random third party GUI that Nix appears to package. |
adisbladis
force-pushed
the
qtpass-1.2.1
branch
from
4fe58fa
to
1e6a48e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update to latest version.
There is a very serious security vulnerability in qtpass < 1.2.1 relating to password generation.
Any password generated by qtpass ought to be changed.
See IJHack/QtPass#338
CC @hrdinka @zx2c4
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)