nixos/dnscrypt-wrapper: fix rotate script failing to restart the service #33444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rnhmjoj you are right, i just checked my logs and it seems the key was rotated correctly but the service was never restarted. |
|
Are you aware of #33540? |
|
@vcunat well, as of right now there is no real alternative as unbound+dns-tls does not validate the source. |
|
I'm not sure about the possibilities in Unbound; Knot-resolver has a few ways of validating, but this thread isn't a good place and it's not released at this moment yet. |
|
So? |
|
@joachifm Can you backport to 17.09? |
|
@rnhmjoj done |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Sorry it took me a while to notice this.
There is an issue with ca54a86: when the script runs as a normal user
systemctl restart dnscrypt-wrapperfails with "Interactive authentication required." so dnscrypt-wrapper it's never restarted.There a two possible solutions I can think of: running it as root (as it was before) and fixing the permission after or adding a polkit rule. I'd prefer not running as root since it's not really needed.
Things done
cc @makefu