Fix "Complex#finite? returns false for NaN FAILED" #4937
Closed
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The behavior of `Complex#finite?` for NaN was fixed on Ruby 2.5. ``` $ ruby -ve "p Complex(Float::NAN, Float::NAN).finite?" ruby 2.5.0p0 (2017-12-25 revision 61468) [x86_64-darwin14] false $ ruby -ve "p Complex(Float::NAN, Float::NAN).finite?" ruby 2.4.1p111 (2017-03-22 revision 58053) [x86_64-darwin14] true ``` Ref: https://github.com/ruby/ruby/blob/v2_5_0/complex.c#L248 https://github.com/ruby/ruby/blob/v2_5_0/numeric.c#L1731
|
This is duplicated with 825c755 . So I close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior of
Complex#finite?for NaN was fixed onRuby 2.5.
Ref: https://github.com/ruby/ruby/blob/v2_5_0/complex.c#L248
https://github.com/ruby/ruby/blob/v2_5_0/numeric.c#L1731