universal-ctags: 2017-09-22 -> 2018-01-05 #33447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixup of NixOS#33124 (ctags failed to create its temporary files when TMPDIR was not in environment). I used the opportunity to bump version with the improvements made to ctags to help diagnose these kinds of errors: universal-ctags/ctags#1648
mimame
reviewed
Jan 5, 2018
| @@ -2,22 +2,25 @@ | |||
|
|
|||
There was a problem hiding this comment.
@teto Which is your opinion about add libxml2, jansson and libyaml dependencies?
There was a problem hiding this comment.
What are the benefits ? if it's to export the data in some format, I would say let it be. The interface doesn't seem too stable yet. I guess if a popular editor relied on it, it could make sense (I wouldn't call geany popular but I believe it might use this)
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixup of #33124 (ctags failed to
create its temporary files when TMPDIR was not in environment). I used
the opportunity to bump version with the improvements made to ctags to
help diagnose these kinds of errors:
universal-ctags/ctags#1648
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)