mixxx: option for AAC support, fixes #29472 #33587
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adisbladis
requested changes
Jan 8, 2018
| @@ -2,8 +2,11 @@ | |||
| , libopus, libshout, libsndfile, libusb1, libvorbis, pkgconfig | |||
| , portaudio, portmidi, protobuf, qt4, rubberband, scons, sqlite | |||
| , taglib, vampSDK | |||
| , aacSupport ? false, faad2 ? null, mp4v2 ? null | |||
There was a problem hiding this comment.
I would actually prefer this not to be optional unless there is a good reason to.
At the very least I think it should default to true.
|
Pushed to master in 067cac7 Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Ticket open for lack of AAC support (#29472).
I myself also wanted AAC support in Mixxx
Things done
Added a flag "aacSupport" (currently defaulting to false, although I would personally prefer a default to true).
I have tested building and installing the package, with and without this flag set, on NixOS
I have tested mixxx with and without this flag set, observing working AAC support when it is set.
Tested using sandboxing (nix.useSandbox on NixOS, or option
build-use-sandboxinnix.confon non-NixOS)Built on platform(s)
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using
nix-shell -p nox --run "nox-review wip"Tested execution of all binary files (usually in
./result/bin/)Fits CONTRIBUTING.md.