Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xfce: cleanup, hyphenate attributes #33600

Merged
merged 2 commits into from Jan 21, 2018
Merged

xfce: cleanup, hyphenate attributes #33600

merged 2 commits into from Jan 21, 2018

Conversation

lukateras
Copy link
Member

Motivation for this change

This is groundwork for adding Xfce 4.13.

I want to provide Xfce attrset as a NixOS option in #32763, and to do that, I will need to have consistent attribute names between Xfce versions.

I've rebuilt system with this change.

/cc @vcunat @volth

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@lukateras lukateras added the 6.topic: xfce The Xfce Desktop Environment label Jan 8, 2018
vcunat
vcunat approved these changes Jan 21, 2018
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good. (Though hard to see how all the code moves.)

@vcunat vcunat merged commit f7a9f96 into NixOS:master Jan 21, 2018
vcunat added a commit that referenced this pull request Jan 21, 2018
@vcunat
Merge #33600: xfce: cleanup, hyphenate attributes
5402412
@lukateras
Copy link
Member Author

Perhaps, although in that case I would like to see such function in lib, and see all entries in pkgs/top-level/rename.nix use it.

@vcunat
Copy link
Member

vcunat commented Jan 21, 2018 •
edited

There have been discussions about that. So far, noone's managed a way that wouldn't be annoying with nix-env -qa, as you can't really make a difference...

@vcunat
Copy link
Member

vcunat commented Jan 21, 2018

Hmm, then we're doing either aliases or overlays wrong :-) but maybe it's a bit difficult.

@vcunat
Copy link
Member

vcunat commented Jan 21, 2018 •
edited

By "wrong" I meant that my intuitive expectation from aliases is that whatever I do, it doesn't matter which name I use (except for the deprecation warning, perhaps).

@jtojnar jtojnar mentioned this pull request Jul 6, 2018
Merged
9 tasks
@pukkamustard pukkamustard mentioned this pull request Jan 3, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
6.topic: xfce The Xfce Desktop Environment 10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lukateras @vcunat @GrahamcOfBorg