Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron-cash: 3.0.0 -> 3.1.1 #33582

Merged
merged 1 commit into from Jan 7, 2018
Merged

electron-cash: 3.0.0 -> 3.1.1 #33582

merged 1 commit into from Jan 7, 2018

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Jan 7, 2018

Motivation for this change

This update addresses the same vulnerability in #33548

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change (none)
  • Tested execution of all binary files (works fine)
  • Fits CONTRIBUTING.md.

cc @Lassulus

@adisbladis
Copy link
Member

@GrahamcOfBorg build electron-cash

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

error: while evaluating the attribute 'propagatedBuildInputs' of the derivation 'electron-cash-3.1.1' at /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/stdenv/generic/make-derivation.nix:134:11:
while evaluating the attribute 'propagatedBuildInputs' of the derivation 'python3.6-keepkey-4.0.0' at /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/stdenv/generic/make-derivation.nix:134:11:
while evaluating the attribute 'propagatedBuildInputs' of the derivation 'python3.6-hidapi-0.7.99.post21' at /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/stdenv/generic/make-derivation.nix:134:11:
while evaluating 'getOutput' at /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/attrsets.nix:450:23, called from undefined position:
while evaluating anonymous function at /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/stdenv/generic/make-derivation.nix:99:17, called from undefined position:
while evaluating the attribute 'udev' at /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/top-level/all-packages.nix:13365:3:
while evaluating 'callPackageWith' at /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:113:35, called from /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/top-level/all-packages.nix:13298:13:
while evaluating 'makeOverridable' at /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:72:24, called from /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:117:8:
while evaluating anonymous function at /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/systemd/default.nix:1:1, called from /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:74:12:
assertion failed at /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/systemd/default.nix:9:1

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: aarch64-linux

Successfully installed Electron-Cash-3.1.1
/build/Electron Cash-3.1.1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/2666b5n4a7nhvyx9kcwrcw9clnjhqala-electron-cash-3.1.1
strip is /nix/store/c6qj0j45xizkrx58i65j75a5ysmqhgrs-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/2666b5n4a7nhvyx9kcwrcw9clnjhqala-electron-cash-3.1.1/lib  /nix/store/2666b5n4a7nhvyx9kcwrcw9clnjhqala-electron-cash-3.1.1/bin
patching script interpreter paths in /nix/store/2666b5n4a7nhvyx9kcwrcw9clnjhqala-electron-cash-3.1.1
checking for references to /build in /nix/store/2666b5n4a7nhvyx9kcwrcw9clnjhqala-electron-cash-3.1.1...
wrapping `/nix/store/2666b5n4a7nhvyx9kcwrcw9clnjhqala-electron-cash-3.1.1/bin/electron-cash'...
/nix/store/2666b5n4a7nhvyx9kcwrcw9clnjhqala-electron-cash-3.1.1

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

Successfully installed Electron-Cash-3.1.1
/tmp/nix-build-electron-cash-3.1.1.drv-0/Electron Cash-3.1.1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/pa2jqj1c0jr3596cspzpq0wqxyr5p2rg-electron-cash-3.1.1
strip is /nix/store/wxn5gn8amxm1w0ikcx4gbs8a17wvss4j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/pa2jqj1c0jr3596cspzpq0wqxyr5p2rg-electron-cash-3.1.1/lib  /nix/store/pa2jqj1c0jr3596cspzpq0wqxyr5p2rg-electron-cash-3.1.1/bin 
patching script interpreter paths in /nix/store/pa2jqj1c0jr3596cspzpq0wqxyr5p2rg-electron-cash-3.1.1
checking for references to /tmp/nix-build-electron-cash-3.1.1.drv-0 in /nix/store/pa2jqj1c0jr3596cspzpq0wqxyr5p2rg-electron-cash-3.1.1...
wrapping `/nix/store/pa2jqj1c0jr3596cspzpq0wqxyr5p2rg-electron-cash-3.1.1/bin/electron-cash'...
/nix/store/pa2jqj1c0jr3596cspzpq0wqxyr5p2rg-electron-cash-3.1.1

@adisbladis adisbladis merged commit 00cf3ad into NixOS:master Jan 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants