Relax atomic operations on performance counter values #3094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkaiser
force-pushed
the
relaxed_atomic_operations
branch
from
b68bc9c
to
cac03f7
Compare
sithhell
reviewed
Jan 14, 2018
hpx/util/get_and_reset_value.hpp
Outdated
| if (reset) | ||
| value.store(0); | ||
| value.store(0, std::memory_order_release); |
There was a problem hiding this comment.
would it make sense to replace the code with something like this:
if (reset)
return value.exchange(0, std:.memory_order_acq_rel);
else
return value.load(std::memory_order_relaxed);
?
There was a problem hiding this comment.
I'm not sure, if using value.load(std::memory_order_relaxed); would be sufficient, but otherwise this could be done, yes.
There was a problem hiding this comment.
I'm not sure about using relaxed either. The idea was: when reading the value, we don't require any ordering since it shouldn't matter if we read an old value.
hkaiser
force-pushed
the
relaxed_atomic_operations
branch
from
cac03f7
to
d1a9e13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relaxes the atomic operations on performance counter values