busybox: 1.27.2 -> 1.28.0 #33584
Closed
busybox: 1.27.2 -> 1.28.0 #33584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. bootstrap tools still build fine, which is usually the concern here. |
andir
reviewed
Jan 11, 2018
| static NORETURN void run_applet_and_exit(const char *name, char **argv) | ||
| { | ||
| # if ENABLE_BUSYBOX | ||
| - if (is_prefixed_with(name, "busybox")) | ||
| + if (strstr(name, "busybox") != 0) | ||
| exit(busybox_main(argv)); | ||
| + if (strstr(name, "busybox") != 0) |
There was a problem hiding this comment.
probably a nitpick but the indention is a bit off here
| lbb_prepare("busybox" IF_FEATURE_INDIVIDUAL(, argv)); | ||
| # if !ENABLE_BUSYBOX | ||
| - if (argv[1] && is_prefixed_with(bb_basename(argv[0]), "busybox")) | ||
| + if (argv[1] && strstr(bb_basename(argv[0]), "busybox") != 0) | ||
| + if (argv[1] && strstr(bb_basename(argv[0]), "busybox") != 0) |
There was a problem hiding this comment.
probably a nitpick but the indention is a bit off here
| @@ -27,35 +27,20 @@ let | |||
| in | |||
|
|
|||
| stdenv.mkDerivation rec { | |||
| name = "busybox-1.27.2"; | |||
| name = "busybox-1.28.0"; | |||
There was a problem hiding this comment.
All of the security patches that you removed are in this release. So nothing to worry here 👍
adisbladis
force-pushed
the
busybox-1_28_0
branch
from
2e169e4
to
6956d66
Compare
NeQuissimus
approved these changes
Jan 11, 2018
|
@GrahamcOfBorg eval |
GrahamcOfBorg
added
10.rebuild-darwin: 0
10.rebuild-linux: 0
and removed
10.rebuild-darwin: 1-10
10.rebuild-linux: 11-100
labels
|
This was pushed in 65774cb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)cc maintainer @viric