Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

discord: fix desktop notifications not appearing #33585

Closed
wants to merge 1 commit into from
Closed

discord: fix desktop notifications not appearing #33585

wants to merge 1 commit into from

Conversation

kliu128
Copy link

@kliu128 kliu128 commented Jan 7, 2018

Motivation for this change

Discord notifications did not appear, even when "Enable desktop notifications" was checked in the client.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dtzWill dtzWill mentioned this pull request Jan 9, 2018
Closed
8 tasks
@MP2E
Copy link

MP2E commented Jan 11, 2018

Thanks for the PR! Just to make sure, does #33666 also fix this issue? It seems to have another fix as well, so I went ahead and merged that one. But if notifications still aren't appearing, please reopen!

@MP2E MP2E closed this Jan 11, 2018
@kliu128
Copy link
Author

kliu128 commented Jan 12, 2018

Yes, that PR fixes the issue very nicely! This one is no longer necessary.

@kliu128 kliu128 deleted the patch-1 branch January 12, 2018 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kliu128 @MP2E @GrahamcOfBorg @Janik-Haag