Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mesa: set sysconfdir to /run/opengl-driver/etc #33590

Merged
merged 1 commit into from Jan 21, 2018
Merged

mesa: set sysconfdir to /run/opengl-driver/etc #33590

merged 1 commit into from Jan 21, 2018

Conversation

corngood
Copy link
Contributor

@corngood corngood commented Jan 8, 2018

This allows drirc to be found.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@corngood
mesa: set sysconfdir to /run/opengl-driver/etc
af32623 
This allows drirc to be found.
@corngood
Copy link
Contributor Author

corngood commented Jan 8, 2018

@vcunat since you made the comment about drirc.

I used ${driverLink}/etc in case you could override drirc with hardware.opengl.extraPackages, but i'm not totally sure if that's possible. ${driver}/etc would also work for the default drirc.

PR to staging because mesa.

@corngood
Copy link
Contributor Author

corngood commented Jan 8, 2018

Tested with LIBGL_DEBUG=1 glxgears to confirm the /etc/drirc warning goes away.

@vcunat
Copy link
Member

vcunat commented Jan 21, 2018

The override would be possible with minor changes in the code that creates the /run/opengl-driver* paths.

@vcunat vcunat self-assigned this Jan 21, 2018
@vcunat vcunat merged commit af32623 into NixOS:staging Jan 21, 2018
vcunat added a commit that referenced this pull request Jan 21, 2018
@vcunat
Merge #33590: mesa: make it find drirc
a0f8e3a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees

@vcunat vcunat

Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@corngood @vcunat @GrahamcOfBorg