Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meld: 3.16.4 -> 3.18.0 #33605

Merged
merged 2 commits into from Jan 16, 2018
Merged

meld: 3.16.4 -> 3.18.0 #33605

merged 2 commits into from Jan 16, 2018

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Jan 8, 2018

Motivation for this change

Update.

Disable some tests because they fail at writing into $HOME.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jtojnar
Copy link
Contributor

jtojnar commented Jan 8, 2018

Interestingly enough, the tests work on 3.19 with some fiddling: jtojnar@d8d7756

@jtojnar jtojnar merged commit d02d062 into NixOS:master Jan 16, 2018
@vbgl vbgl deleted the meld-3.18 branch January 17, 2018 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbgl @jtojnar @GrahamcOfBorg