Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tensorflow: revert to wheel-based build and update to 1.5.0 #34418

Closed
wants to merge 2 commits into from
Closed

Tensorflow: revert to wheel-based build and update to 1.5.0 #34418

wants to merge 2 commits into from

Conversation

jyp
Copy link
Contributor

@jyp jyp commented Jan 30, 2018

Please note: this PR should not be merged until #33559 is cleared.

Motivation for this change

Two motivations:

  • Tensorflow does not currently build in master
  • Upstream update
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jyp jyp requested a review from FRidh as a code owner January 30, 2018 12:59
@jyp
pythonPackages.tensorflow: 1.3.1 -> 1.5.0
68692d3 
Also revert to a wheel-based build (the bazel-based build is broken
and it is unclear how to repair it)
@FRidh
Copy link
Member

FRidh commented Jan 30, 2018

Tensorflow does not currently build in master

Why not fix the source build instead of reverting to the wheel-based solution?

@jyp
Copy link
Contributor Author

jyp commented Jan 30, 2018

@FRidh Because I do not understand the bazel-based build. @abbradar constructed it but he has been unresponsive for a couple of months. Furthermore, it looks like bazel itself is in a bad state (the derivation has patches which are not even applied). I spent a day trying to fix it without success.

This was referenced Jan 30, 2018
Closed
Closed
@jyp jyp closed this Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jyp @FRidh @GrahamcOfBorg