Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

godot: 2.1.4 -> 3.0 #34421

Closed
wants to merge 1 commit into from
Closed

godot: 2.1.4 -> 3.0 #34421

wants to merge 1 commit into from

Conversation

lboklin
Copy link

@lboklin lboklin commented Jan 30, 2018

Motivation for this change

Godot 3.0 is released!

Things done

Version bump to a new major stable version.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@lboklin
Copy link
Author

lboklin commented Jan 30, 2018

I don't know how to include Xge.h, so I disabled touch features via compilation flag. I tried including libXext but it made no difference. If anyone knows a fix please let me know.

@jtojnar
Copy link
Contributor

jtojnar commented Feb 14, 2018

See also #34971

@lboklin
Copy link
Author

lboklin commented Feb 14, 2018

@jtojnar That PR appears to handle it more elegantly. If it works then I'd recommend it over mine.

@xeji xeji mentioned this pull request Mar 26, 2018
8 tasks
@xeji
Copy link
Contributor

xeji commented Mar 27, 2018

Thanks! Since #34971 was just merged, this is probably no longer needed.

@lboklin
Copy link
Author

lboklin commented Mar 28, 2018

@xeji Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants