Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreak broadcast_wait_for_2822 test #3098

Merged
merged 1 commit into from Jan 14, 2018
Merged

Unbreak broadcast_wait_for_2822 test #3098

merged 1 commit into from Jan 14, 2018

Conversation

sithhell
Copy link
Member

Unbreak broadcast_wait_for_2822 test

Proposed Changes

  • Properly testing the broadcast for completion, not relying on particular timing for the test to succeed

@sithhell sithhell added this to the 1.1.0 milestone Jan 12, 2018
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hkaiser hkaiser merged commit a3ed07c into master Jan 14, 2018
@hkaiser hkaiser deleted the unbreak_test branch January 14, 2018 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants