Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opencv 3.3.1 release 17.09 #33783

Merged
merged 5 commits into from Feb 17, 2018
Merged

Opencv 3.3.1 release 17.09 #33783

merged 5 commits into from Feb 17, 2018

Conversation

roelvandijk
Copy link
Contributor

Motivation for this change

Upgrading OpenCV from 3.2.0 to 3.3.1. Contains many bugfixes.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of most binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

abbradar and others added 5 commits January 12, 2018 12:19
@abbradar @roelvandijk
opencv: use BLAS and eigen by default
4dff61e 
Gives a performance boost.

(cherry picked from commit 7bf1913)
@abbradar @roelvandijk
treewide: use default compiler for cuda
0f5464f 
(cherry picked from commit 378bfba)
@abbradar @roelvandijk
opencv3: use older cudatoolkit
a370a4e 
(cherry picked from commit 59f51eb)
@basvandijk @roelvandijk
opencv: 3.2.0 -> 3.3.0
b72bfca 
Release notes: https://opencv.org/opencv-3-3.html

The contrib module cnn_3dobj is disabled because it fails to build.

The contrib module dnn_modern is disabled because it causes:
opencv/opencv_contrib#823
@basvandijk @roelvandijk
opencv: 3.3.0 -> 3.3.1
f0b79ee
@joachifm
Copy link
Contributor

@basvandijk thoughts on backporting these?

@basvandijk
Copy link
Member

We've been using these patches at LumiGuide for some time now and they work as expected.

(I would also like to get opencv-3.4.0 in 17.09 but that might be more difficult).

@joachifm joachifm merged commit 91ec527 into NixOS:release-17.09 Feb 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@roelvandijk @joachifm @basvandijk @GrahamcOfBorg @abbradar