Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auquantoolbox: init at 2.0.8 #33782

Closed
wants to merge 3 commits into from
Closed

auquantoolbox: init at 2.0.8 #33782

wants to merge 3 commits into from
+98 −0

Conversation

pallavagarwal07
Copy link
Contributor

@pallavagarwal07 pallavagarwal07 commented Jan 12, 2018 •
edited
Loading

Motivation for this change

I need this package for development.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

FRidh
FRidh requested changes Jan 12, 2018
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • name should be removed
  • meta.maintainers is missing
  • meta.license is missing
  • requests is most likely a propagatedBuildInput

pkgs/development/python-modules/pandas-datareader/default.nix Outdated
pandas requests requests-ftp requests-file python-dateutil
pytz numpy urllib3 idna chardet certifi six
];
doCheck = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when disabling tests or builds a comment with a reason should be left

pkgs/top-level/python-packages.nix Outdated
@@ -11702,6 +11702,14 @@ in {
blas = pkgs.openblasCompat;
};

auquantoolbox = callPackage ../development/python-modules/auquantoolbox { };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try not to make the ordering even worse

@pallavagarwal07
Copy link
Contributor Author

@FRidh Fixed most of the things. I don't know who to put as maintainer.

@samueldr samueldr added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 11, 2018
@infinisil infinisil added the 8.has: package (new) This PR adds a new package label Mar 30, 2019
@prusnak
Copy link
Member

prusnak commented May 9, 2020

@pallavagarwal07 Can you please rebase your PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pallavagarwal07 @prusnak @FRidh @samueldr @infinisil @GrahamcOfBorg