flootty: init at 3.2.1 #33793
Merged
flootty: init at 3.2.1 #33793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Jan 13, 2018
pkgs/top-level/python-packages.nix
Outdated
| @@ -225,6 +225,8 @@ in { | |||
|
|
|||
| diff-match-patch = callPackage ../development/python-modules/diff-match-patch { }; | |||
|
|
|||
| flootty = callPackage ../development/python-modules/flootty { }; | |||
There was a problem hiding this comment.
This does not look like a python library to me. If that is the case please move it out of this module as we build pythonPackages against multiple python versions.
There was a problem hiding this comment.
Should I also move the derivation? If so, what do you think is the right place? development/tools? applications/networking? Somewhere else?
Mic92
reviewed
Jan 13, 2018
| @@ -0,0 +1,19 @@ | |||
| { stdenv, buildPythonPackage, fetchPypi }: | |||
|
|
|||
| buildPythonPackage rec { | |||
There was a problem hiding this comment.
buildPythonApplication looks more appropriate to me.
|
@GrahamcOfBorg build flootty |
There was a problem hiding this comment.
Success for system: x86_64-darwin
writing entry points to Flootty.egg-info/entry_points.txt
reading manifest file 'Flootty.egg-info/SOURCES.txt'
writing manifest file 'Flootty.egg-info/SOURCES.txt'
running build_ext
----------------------------------------------------------------------
Ran 0 tests in 0.000s
OK
/nix/store/z6ppq00xc6r0fjybvbb0fv97422l9q8s-Flootty-3.2.1
There was a problem hiding this comment.
Success for system: x86_64-linux
writing entry points to Flootty.egg-info/entry_points.txt
reading manifest file 'Flootty.egg-info/SOURCES.txt'
writing manifest file 'Flootty.egg-info/SOURCES.txt'
running build_ext
----------------------------------------------------------------------
Ran 0 tests in 0.000s
OK
/nix/store/6a356zjkqas1gb5m587vbmwsq6nrim8b-Flootty-3.2.1
There was a problem hiding this comment.
Success for system: aarch64-linux
writing entry points to Flootty.egg-info/entry_points.txt
reading manifest file 'Flootty.egg-info/SOURCES.txt'
writing manifest file 'Flootty.egg-info/SOURCES.txt'
running build_ext
----------------------------------------------------------------------
Ran 0 tests in 0.000s
OK
/nix/store/kbzwq9k63hcqcbnz8pdh5csfl4qqsl43-Flootty-3.2.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Adding a tool I use – the Emacs & Vim plugins for Floobits are already in nixpkgs, and this complements them.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)