PICARD-1175: save and restore CD Lookup dialog and headers states #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zas
changed the title
samj1912
reviewed
Feb 1, 2018
| self.save_state() | ||
| QtWidgets.QDialog.reject(self) | ||
|
|
||
| def restore_state(self): |
There was a problem hiding this comment.
Any reason why save_state saves both size and header state but restore state only restores size? We should maintain consistency in behavior or function name
There was a problem hiding this comment.
Because restoring is a two-steps action, the size of dialog is restored just after it is created, but the header stuff is done after the header is actually created. I didn't dig if it is still needed, but all save/restore are made like this. I don't want to bother with that for now, i have ideas on how to make this much simpler (and with less code redundancy).
samj1912
approved these changes
Feb 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Save CD Lookup dialog size and header state to persist options, and restore them when needed.
Problem
Every time a CD lookup is done you have to scroll or make the resulting window larger to see all the information to distinguish releases, especially the catalog number and barcode (as the last columns). The barcode column often is cut off.
Picard should store and remember that window setting (and maybe auto-size the smaller columns).
Solution
Save CD Lookup dialog size and header state to persist options, and restore them when needed.