Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php: 7.2.1 -> 7.2.2, xdebug: 2.6.0beta1 -> 2.6.0 #34496

Merged
merged 3 commits into from Feb 3, 2018
Merged

php: 7.2.1 -> 7.2.2, xdebug: 2.6.0beta1 -> 2.6.0 #34496

merged 3 commits into from Feb 3, 2018

Conversation

etu
Copy link
Contributor

@etu etu commented Feb 1, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@etu etu changed the title Php722 php: 7.2.1 -> 7.2.2, xdebug: 2.6.0beta1 -> 2.6.0 Feb 1, 2018
@etu
Copy link
Contributor Author

etu commented Feb 3, 2018

It's worth mentioning that the php71 upgrade doesn't go through the nox-review wip part entirely because of a build failure in qcachegrind: #34552

The packages that are needed to build by the php71 upgrade is (generated by nox-review wip):

nix-build -A php71Packages.ast -A php71Packages.phpcs -A nagios -A php71Packages.composer -A php71Packages.v8 -A qcachegrind -A hhvm -A php71Packages.box -A php71Packages.memcached -A php71Packages.igbinary -A php71Packages.pcs -A php-embed -A arcanist -A php71Packages.redis -A piwik -A limesurvey -A nextcloud-news-updater -A php71Packages.v8js -A yle-dl -A php -A php71Packages.yaml -A php71Packages.phpcbf -A drush -A php71Packages.mailparse -A wp-cli -A php71Packages.couchbase -A php71Packages.imagick -A php71Packages.apcu -A php71Packages.php-cs-fixer -A kcachegrind -A php71Packages.php-parallel-lint -A php71Packages.zmq -A php71Packages.xdebug /home/etu/code/nixpkgs

All the packages build except qcachegrind which was broken before as well.

@adisbladis adisbladis merged commit c56b13a into NixOS:master Feb 3, 2018
@adisbladis
Copy link
Member

Thanks!

@etu etu deleted the php722 branch February 3, 2018 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@etu @adisbladis @GrahamcOfBorg