xpwn: build usb-based tools by replacing libusb1 dep with libusb #34502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise the build fails to detect libusb and doesn't build the 'xpwn' and 'dfu-util' tools. New tools run but I don't have any suitable devices to test :). (I believe latest iGadgets need a newer version of xpwn anyway)
LnL7
approved these changes
Feb 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drive-by, noticed libusb wasn't being detected.
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)Otherwise the build fails to detect libusb and doesn't build
the 'xpwn' and 'dfu-util' tools.
New tools run but I don't have any suitable devices to test :).
(I believe latest iGadgets need a newer version of xpwn anyway)