Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wine-stable: 2.0.3 -> 3.0 #34031

Closed
wants to merge 1 commit into from
Closed

wine-stable: 2.0.3 -> 3.0 #34031

wants to merge 1 commit into from

Conversation

ikervagyok
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@MP2E
Copy link

MP2E commented Jan 19, 2018

Pushed, thanks!

@MP2E MP2E closed this Jan 19, 2018
@ikervagyok
Copy link
Contributor Author

@volth seems like it: https://github.com/wine-compholio/wine-staging/ latest commit is 2 months old

@ikervagyok
Copy link
Contributor Author

@volth i'll look into it in a few hours. thanks for mentioning this

@ikervagyok
Copy link
Contributor Author

ikervagyok commented Jan 22, 2018 •
edited

@volth i'd update wine unstable to match stable, but leave staging as it is atm. or did i miss something (again)
EDIT: i'd rather not touch wine unstable yet, as the wine staging logic (in staging.nix) is depending on wine staging and wine unstable having the same version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ikervagyok @MP2E @GrahamcOfBorg