geis: fix python programs #34036
Merged
geis: fix python programs #34036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jraygauthier
force-pushed
the
jrg/geis-fix-python-prog
branch
from
07eeb7a
to
7c6bf14
Compare
|
@GrahamcOfBorg build geis |
There was a problem hiding this comment.
Success for system: aarch64-linux
shrinking /nix/store/4vq8bbgkpgzcsdww4344sr2fslpzz2sp-geis-2.2.17/lib/python3.6/site-packages/_geis_bindings.so
shrinking /nix/store/4vq8bbgkpgzcsdww4344sr2fslpzz2sp-geis-2.2.17/lib/libgeis.so.1.3.0
gzipping man pages under /nix/store/4vq8bbgkpgzcsdww4344sr2fslpzz2sp-geis-2.2.17/share/man/
strip is /nix/store/jwz859pxqj7sl2dbwvmxkx68jp774izb-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/4vq8bbgkpgzcsdww4344sr2fslpzz2sp-geis-2.2.17/lib /nix/store/4vq8bbgkpgzcsdww4344sr2fslpzz2sp-geis-2.2.17/bin
patching script interpreter paths in /nix/store/4vq8bbgkpgzcsdww4344sr2fslpzz2sp-geis-2.2.17
/nix/store/4vq8bbgkpgzcsdww4344sr2fslpzz2sp-geis-2.2.17/bin/.pygeis-wrapped: interpreter directive changed from "/usr/bin/python3" to "/nix/store/mn2c28fa7mp8ck3p74n80nls6g2w7flw-python3-3.6.4/bin/python3"
/nix/store/4vq8bbgkpgzcsdww4344sr2fslpzz2sp-geis-2.2.17/bin/.geisview-wrapped: interpreter directive changed from "/usr/bin/python3" to "/nix/store/mn2c28fa7mp8ck3p74n80nls6g2w7flw-python3-3.6.4/bin/python3"
checking for references to /build in /nix/store/4vq8bbgkpgzcsdww4344sr2fslpzz2sp-geis-2.2.17...
/nix/store/4vq8bbgkpgzcsdww4344sr2fslpzz2sp-geis-2.2.17
There was a problem hiding this comment.
Success for system: x86_64-linux
shrinking /nix/store/fwavwag77a2526316xldjxq62vvrnyl3-geis-2.2.17/lib/python3.6/site-packages/_geis_bindings.so
shrinking /nix/store/fwavwag77a2526316xldjxq62vvrnyl3-geis-2.2.17/bin/.geistest-wrapped
gzipping man pages under /nix/store/fwavwag77a2526316xldjxq62vvrnyl3-geis-2.2.17/share/man/
strip is /nix/store/mdyy001q67hiks0g24ra53z7ckm4jfr4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/fwavwag77a2526316xldjxq62vvrnyl3-geis-2.2.17/lib /nix/store/fwavwag77a2526316xldjxq62vvrnyl3-geis-2.2.17/bin
patching script interpreter paths in /nix/store/fwavwag77a2526316xldjxq62vvrnyl3-geis-2.2.17
/nix/store/fwavwag77a2526316xldjxq62vvrnyl3-geis-2.2.17/bin/.geisview-wrapped: interpreter directive changed from "/usr/bin/python3" to "/nix/store/53dyjh7xjhnbibqllr7j27lk2h98n7j7-python3-3.6.4/bin/python3"
/nix/store/fwavwag77a2526316xldjxq62vvrnyl3-geis-2.2.17/bin/.pygeis-wrapped: interpreter directive changed from "/usr/bin/python3" to "/nix/store/53dyjh7xjhnbibqllr7j27lk2h98n7j7-python3-3.6.4/bin/python3"
checking for references to /tmp/nix-build-geis-2.2.17.drv-0 in /nix/store/fwavwag77a2526316xldjxq62vvrnyl3-geis-2.2.17...
/nix/store/fwavwag77a2526316xldjxq62vvrnyl3-geis-2.2.17
There was a problem hiding this comment.
Failure for system: x86_64-darwin
Package ‘geis-2.2.17’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/pkgs/development/libraries/geis/default.nix:49 is not supported on ‘x86_64-darwin’, refusing to evaluate.
a) For `nixos-rebuild` you can set
{ nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.
b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
{ allowBroken = true; }
to ~/.config/nixpkgs/config.nix.
FRidh
reviewed
Jan 21, 2018
|
|
||
| preFixup = '' | ||
| buildPythonPath "$out $pythonPath" | ||
| gappsWrapperArgs+=(--prefix PYTHONPATH : "$program_PYTHONPATH") |
There was a problem hiding this comment.
Have you tried with --set first? --prefix should be avoided as an existing PYTHONPATH may leak in.
FRidh
reviewed
Jan 21, 2018
| preFixup = '' | ||
| buildPythonPath "$out $pythonPath" | ||
| gappsWrapperArgs+=(--prefix PYTHONPATH : "$program_PYTHONPATH") | ||
| gappsWrapperArgs+=(--prefix LD_LIBRARY_PATH : "$out/lib") |
There was a problem hiding this comment.
Patching the code to hardcode a path to the required libraries is the preferred solution.
There was a problem hiding this comment.
@FRidh: applied suggested changes to PR.
jraygauthier
force-pushed
the
jrg/geis-fix-python-prog
branch
from
7c6bf14
to
aa54ac3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Non working python programs.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)Also ran the only dependent program
/szhw3miyaqfxsw2lwkrsz4qdp03hd7vz-touchegg-1.1.1/bin/toucheggsuccessfully.