Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.supervise_api: 0.2.0 -> 0.3.0 #34359

Merged
merged 1 commit into from Jan 29, 2018
Merged

Conversation

catern
Copy link
Contributor

@catern catern commented Jan 28, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this package Linux only? This should probably be specified in meta.

@@ -8,13 +8,13 @@

buildPythonPackage rec {
pname = "supervise_api";
version = "0.2.0";
version = "0.3.0";

name = "${pname}-${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove name.

@FRidh
Copy link
Member

FRidh commented Jan 29, 2018

@GrahamcOfBorg build python2.pkgs.supervise_api python3.pkgs.supervise_api

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success on x86_64-linux (full log)

Partial log (click to expand)

Successfully installed supervise-api-0.3.0
/tmp/nix-build-python3.6-supervise_api-0.3.0.drv-0/supervise_api-0.3.0
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/qhd7vl3h605arq98mm9ni4ymakmjp1ff-python3.6-supervise_api-0.3.0
strip is /nix/store/mdyy001q67hiks0g24ra53z7ckm4jfr4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/qhd7vl3h605arq98mm9ni4ymakmjp1ff-python3.6-supervise_api-0.3.0/lib 
patching script interpreter paths in /nix/store/qhd7vl3h605arq98mm9ni4ymakmjp1ff-python3.6-supervise_api-0.3.0
checking for references to /tmp/nix-build-python3.6-supervise_api-0.3.0.drv-0 in /nix/store/qhd7vl3h605arq98mm9ni4ymakmjp1ff-python3.6-supervise_api-0.3.0...
/nix/store/1sgc5rwyp7pfhprq773gl42vxxnml908-python2.7-supervise_api-0.3.0
/nix/store/qhd7vl3h605arq98mm9ni4ymakmjp1ff-python3.6-supervise_api-0.3.0

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success on aarch64-linux (full log)

Partial log (click to expand)

Successfully installed supervise-api-0.3.0
/build/supervise_api-0.3.0
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/9d69zzbmzi6fnylvidfd869kpw2n8zl6-python3.6-supervise_api-0.3.0
strip is /nix/store/jwz859pxqj7sl2dbwvmxkx68jp774izb-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/9d69zzbmzi6fnylvidfd869kpw2n8zl6-python3.6-supervise_api-0.3.0/lib
patching script interpreter paths in /nix/store/9d69zzbmzi6fnylvidfd869kpw2n8zl6-python3.6-supervise_api-0.3.0
checking for references to /build in /nix/store/9d69zzbmzi6fnylvidfd869kpw2n8zl6-python3.6-supervise_api-0.3.0...
/nix/store/qadkkm3hjzmwlrm2p6kqm3v26d4i0bxb-python2.7-supervise_api-0.3.0
/nix/store/9d69zzbmzi6fnylvidfd869kpw2n8zl6-python3.6-supervise_api-0.3.0

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘supervise-1.1.0’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/tools/system/supervise/default.nix:15 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@FRidh FRidh merged commit ad069c3 into NixOS:master Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants