pythonPackages.discordpy: Use websockets==3.4 #34353
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
discord.py only works with websockets<4 See Rapptz/discord.py#973
|
@GrahamcOfBorg build python3Packages.discordpy |
There was a problem hiding this comment.
Success for system: x86_64-linux
Installing collected packages: discord.py
Successfully installed discord.py-0.16.12
/tmp/nix-build-python3.6-discord.py-0.16.12.drv-0/discord.py-0.16.12
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/0jlffjsyfnxq2vb3avgm3an4v7m4c1sy-python3.6-discord.py-0.16.12
strip is /nix/store/mdyy001q67hiks0g24ra53z7ckm4jfr4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/0jlffjsyfnxq2vb3avgm3an4v7m4c1sy-python3.6-discord.py-0.16.12/lib
patching script interpreter paths in /nix/store/0jlffjsyfnxq2vb3avgm3an4v7m4c1sy-python3.6-discord.py-0.16.12
checking for references to /tmp/nix-build-python3.6-discord.py-0.16.12.drv-0 in /nix/store/0jlffjsyfnxq2vb3avgm3an4v7m4c1sy-python3.6-discord.py-0.16.12...
/nix/store/0jlffjsyfnxq2vb3avgm3an4v7m4c1sy-python3.6-discord.py-0.16.12
There was a problem hiding this comment.
Success for system: aarch64-linux
Installing collected packages: discord.py
Successfully installed discord.py-0.16.12
/build/discord.py-0.16.12
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/dr8bayf7qh48gv3aqyim6dv3hvz804n1-python3.6-discord.py-0.16.12
strip is /nix/store/jwz859pxqj7sl2dbwvmxkx68jp774izb-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/dr8bayf7qh48gv3aqyim6dv3hvz804n1-python3.6-discord.py-0.16.12/lib
patching script interpreter paths in /nix/store/dr8bayf7qh48gv3aqyim6dv3hvz804n1-python3.6-discord.py-0.16.12
checking for references to /build in /nix/store/dr8bayf7qh48gv3aqyim6dv3hvz804n1-python3.6-discord.py-0.16.12...
/nix/store/dr8bayf7qh48gv3aqyim6dv3hvz804n1-python3.6-discord.py-0.16.12
FRidh
requested changes
Jan 29, 2018
| , asyncio | ||
| , aiohttp | ||
| , websockets | ||
| , pynacl | ||
| }: | ||
|
|
||
| let |
There was a problem hiding this comment.
The purpose of python-packages.nix is to provide a coherent set of packages that work together. We cannot have any overrides inside python-packages.nix because that may cause collisions. In this case we likely have to mark the package as broken.
There was a problem hiding this comment.
I am doing the same in #34188 which probably means it can only be packaged as an application.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
discord.py only works with websockets<4
See Rapptz/discord.py#973
I have not tested this, since I have no use for discord.py.
I only came across the problem using
nox-reviewon #34352.Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)