Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configure: Use $CPP instead of cpp directly #1824

Merged
merged 1 commit into from Jan 30, 2018
Merged

configure: Use $CPP instead of cpp directly #1824

merged 1 commit into from Jan 30, 2018

Conversation

bgamari
Copy link
Contributor

@bgamari bgamari commented Jan 28, 2018

The latter breaks in the case of cross-compilation, when cpp bears a target prefix.

@shlevy
Copy link
Member

shlevy commented Jan 28, 2018

Wouldn't it be better to use AC_PROG_CPP and $CPP?

@bgamari
Copy link
Contributor Author

bgamari commented Jan 28, 2018

Yes, probably. Fixed although I'm waiting for a build to test it.

@bgamari
configure: Use $CPP instead of cpp directly
f93e890 
The latter breaks in the case of cross-compilation, when `cpp` bears a
target prefix.
@bgamari bgamari changed the title configure: Use $CC instead of cpp directly configure: Use $CPP instead of cpp directly Jan 29, 2018
@dtzWill
Copy link
Member

dtzWill commented Jan 30, 2018

Woo this fixes nixUnstable cross-compilation for me!

Well, coupled with a few other things (disabling tests on aws-sdk-cpp, etc.).

Result has a few undesirable references but it builds! :)

@shlevy shlevy merged commit f93e890 into NixOS:master Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bgamari @shlevy @dtzWill