Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ranger: 1.8.1 -> 1.9.0 #34362

Merged
merged 1 commit into from Jan 28, 2018
Merged

ranger: 1.8.1 -> 1.9.0 #34362

merged 1 commit into from Jan 28, 2018

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Jan 28, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member

grahamc commented Jan 28, 2018

@GrahamcOfBorg build ranger

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success on x86_64-linux

Partial log (click to expand)

platform linux2 -- Python 2.7.14, pytest-3.3.2, py-1.5.2, pluggy-0.6.0
rootdir: /tmp/nix-build-ranger-v1.9.0.drv-0/source, inifile:
collected 5 items

tests/ranger/container/test_bookmarks.py .                               [ 20%]
tests/ranger/container/test_container.py ..                              [ 60%]
tests/ranger/container/test_fsobject.py ..                               [100%]

=========================== 5 passed in 0.09 seconds ===========================
/nix/store/mzfzgz16fqjxfbcwzca60c1fwikxmbi3-ranger-v1.9.0

Full log

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success on aarch64-linux

Partial log (click to expand)

platform linux2 -- Python 2.7.14, pytest-3.3.2, py-1.5.2, pluggy-0.6.0
rootdir: /build/source, inifile:
collected 5 items

tests/ranger/container/test_bookmarks.py .                               [ 20%]
tests/ranger/container/test_container.py ..                              [ 60%]
tests/ranger/container/test_fsobject.py ..                               [100%]

=========================== 5 passed in 0.34 seconds ===========================
/nix/store/nb7qgxi57xdq9lqs05j6180fmvh4pifp-ranger-v1.9.0

Full log

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success on x86_64-darwin

Partial log (click to expand)

platform darwin -- Python 2.7.14, pytest-3.3.2, py-1.5.2, pluggy-0.6.0
rootdir: /private/tmp/nix-build-ranger-v1.9.0.drv-0/source, inifile:
collected 5 items

tests/ranger/container/test_bookmarks.py .                               [ 20%]
tests/ranger/container/test_container.py ..                              [ 60%]
tests/ranger/container/test_fsobject.py ..                               [100%]

=========================== 5 passed in 0.29 seconds ===========================
/nix/store/rpnaiw8shygp1gl25cg7barilhl6x07b-ranger-v1.9.0

Full log

@magnetophon
Copy link
Member Author

Sorry about the fixups.
I was notified on the #ranger irc that the homepage was changed, then I noticed there wasn't a maintainer yet, and then I messed about with the syntax of meta.
I think we're good now... ;)

@fpletz fpletz merged commit 0cc73f2 into NixOS:master Jan 28, 2018
@magnetophon magnetophon deleted the ranger branch January 28, 2018 23:46
@vcunat
Copy link
Member

vcunat commented Feb 15, 2018

FYI e26a229

vcunat added a commit that referenced this pull request Feb 15, 2018
This was a regression of #34362, and doesn't seem intended.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants