keepass: Change from mono40 to mono50 #34358
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation for change: Issue NixOS#31859 (NixOS#31859) highlighted TLSv1.1 / TLSv1.2 support isn't available with older versions of Mono 4. This change moves to use Mono 5.
|
Any reason why we shouldn't compile with with The other question is why is cc @orivej @copumpkin because they have done mono stuff in the last few weeks. |
|
I don't know enough about mono to know about changing the default, but it seems reasonable to bump the default to a much higher version. |
|
@fpletz @copumpkin The only reason I didn't switch to Mono54 was because I forgot it existed. Was a month or so ago I started looking into this and I forgot what version I was aiming for! I'm happy to look at moving to I'll close this PR and start again with the change. |
|
Please see #34398 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Issue #31859 (#31859) highlighted TLSv1.1 / TLSv1.2
support isn't available with older versions of Mono 4. This change moves to use Mono 5.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)