doitlive: init at 3.0.3 #34361

mbode · 2018-01-28T18:54:21Z

Motivation for this change

Add package doitlive

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

fpletz · 2018-01-28T21:31:03Z

This should rather be in all-packages.nix and not put in pkgs/development/python-modules as it is an executable tool.

fpletz · 2018-01-28T21:31:33Z

@GrahamcOfBorg build pythonPackages.doitlive

GrahamcOfBorg

Failure on aarch64-linux (full log)

Partial log (click to expand)

Reading https://pypi.python.org/simple/pytest/
Download error on https://pypi.python.org/simple/pytest/: [Errno -2] Name or service not known -- Some packages may not be found!
Couldn't find index page for 'pytest' (maybe misspelled?)
Scanning index of all packages (this may take a while)
Reading https://pypi.python.org/simple/
Download error on https://pypi.python.org/simple/: [Errno -2] Name or service not known -- Some packages may not be found!
No local packages or working download links found for pytest
error: Could not find suitable distribution for Requirement.parse('pytest')
builder for '/nix/store/x9d6ixwmqna3f35mg4irq6vwkms1apbc-doitlive-3.0.3.drv' failed with exit code 1
error: build of '/nix/store/x9d6ixwmqna3f35mg4irq6vwkms1apbc-doitlive-3.0.3.drv' failed

GrahamcOfBorg

Success on x86_64-darwin (full log)

Partial log (click to expand)

reading manifest file 'doitlive.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'doitlive.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/3dds2kdx2kkwnd01ichfmxb80gbijixk-doitlive-3.0.3

GrahamcOfBorg

Failure on x86_64-linux (full log)

Partial log (click to expand)

Reading https://pypi.python.org/simple/pytest/
Download error on https://pypi.python.org/simple/pytest/: [Errno -2] Name or service not known -- Some packages may not be found!
Couldn't find index page for 'pytest' (maybe misspelled?)
Scanning index of all packages (this may take a while)
Reading https://pypi.python.org/simple/
Download error on https://pypi.python.org/simple/: [Errno -2] Name or service not known -- Some packages may not be found!
No local packages or working download links found for pytest
error: Could not find suitable distribution for Requirement.parse('pytest')
builder for ‘/nix/store/7idllqrfw69j5pqmksmmpk7yay60k2ii-doitlive-3.0.3.drv’ failed with exit code 1
error: build of ‘/nix/store/7idllqrfw69j5pqmksmmpk7yay60k2ii-doitlive-3.0.3.drv’ failed

dotlambda · 2018-01-29T01:55:14Z

pkgs/development/python-modules/doitlive/default.nix

+
+buildPythonApplication rec {
+  pname = "doitlive";
+  name = "${pname}-${version}";


dotlambda · 2018-01-29T02:00:37Z

pkgs/development/python-modules/doitlive/default.nix

+
+  propagatedBuildInputs = [ click ];
+
+  checkInputs = [ ipython ];


Did you try specifying a custom checkPhase such that the tests are run? This should be something like invoke test oder py.test.

I tried, basically using

checkInputs = with python3Packages; [ pkgs.git ipython pytest ]; LC_ALL="en_US.UTF-8"; checkPhase = "pytest";

Still something like 20 tests were failing due to issues with ipython. Unfortunately could not get it to work. How important is the check phase for python packages?

Okay, let's keep the tests disabled. Please add a comment that there were too many failures or something like that.
However, tests are nice to have for automatic updates.

dotlambda · 2018-03-14T12:27:33Z

pkgs/tools/misc/doitlive/default.nix

+, pkgs, python3Packages }:
+
+python3Packages.buildPythonApplication rec {
+  name = "doitlive-${version}";


dotlambda · 2018-03-14T12:27:53Z

pkgs/tools/misc/doitlive/default.nix

+  name = "doitlive-${version}";
+  version = "3.0.3";
+
+  src = fetchFromGitHub {


Why not fetchPypi?

dotlambda · 2018-03-14T12:30:32Z

pkgs/tools/misc/doitlive/default.nix

+    sha256 = "1y1v7f64fhykm7p9yp1ymx1gj6s8qzcq6ygyf3fzwrvw2jjf3n93";
+  };
+
+  propagatedBuildInputs = with python3Packages; [ pkgs.which click ];


which should be an argument, not pkgs.

Is which called by doitlive? In that case, I think it's better to patch the sources or add makeWrapperArgs = ["--prefix PATH : ${which}/bin"];

dotlambda · 2018-03-14T18:33:56Z

pkgs/tools/misc/doitlive/default.nix

+{ stdenv, pythonPackages }:
+
+pythonPackages.buildPythonApplication rec {
+  name = "${pname}-${version}";


drop this line

dotlambda · 2018-03-14T18:38:49Z

pkgs/top-level/all-packages.nix

@@ -20134,6 +20134,8 @@ with pkgs;

  dbus-map = callPackage ../tools/misc/dbus-map { };

+  doitlive = callPackage ../tools/misc/doitlive { };


I think the right place would be in the TOOLS section, after dlx.

dotlambda · 2018-03-14T19:02:53Z

@GrahamcOfBorg build doitlive

GrahamcOfBorg · 2018-03-14T19:03:17Z

Success on x86_64-linux (full log)

Attempted: doitlive

Partial log (click to expand)

Successfully installed doitlive-3.0.3
/tmp/nix-build-doitlive-3.0.3.drv-0/doitlive-3.0.3
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/a5d3bqg4rq0zgw9rgb271kb12z32ffgz-doitlive-3.0.3
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/a5d3bqg4rq0zgw9rgb271kb12z32ffgz-doitlive-3.0.3/lib  /nix/store/a5d3bqg4rq0zgw9rgb271kb12z32ffgz-doitlive-3.0.3/bin 
patching script interpreter paths in /nix/store/a5d3bqg4rq0zgw9rgb271kb12z32ffgz-doitlive-3.0.3
checking for references to /tmp/nix-build-doitlive-3.0.3.drv-0 in /nix/store/a5d3bqg4rq0zgw9rgb271kb12z32ffgz-doitlive-3.0.3...
wrapping `/nix/store/a5d3bqg4rq0zgw9rgb271kb12z32ffgz-doitlive-3.0.3/bin/doitlive'...
/nix/store/a5d3bqg4rq0zgw9rgb271kb12z32ffgz-doitlive-3.0.3

GrahamcOfBorg · 2018-03-14T19:03:24Z

Success on aarch64-linux (full log)

Attempted: doitlive

Partial log (click to expand)

Successfully installed doitlive-3.0.3
/build/doitlive-3.0.3
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/jqyn5647qjdx1h10i776vpwqga9qzn00-doitlive-3.0.3
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/jqyn5647qjdx1h10i776vpwqga9qzn00-doitlive-3.0.3/lib  /nix/store/jqyn5647qjdx1h10i776vpwqga9qzn00-doitlive-3.0.3/bin
patching script interpreter paths in /nix/store/jqyn5647qjdx1h10i776vpwqga9qzn00-doitlive-3.0.3
checking for references to /build in /nix/store/jqyn5647qjdx1h10i776vpwqga9qzn00-doitlive-3.0.3...
wrapping `/nix/store/jqyn5647qjdx1h10i776vpwqga9qzn00-doitlive-3.0.3/bin/doitlive'...
/nix/store/jqyn5647qjdx1h10i776vpwqga9qzn00-doitlive-3.0.3

mbode requested a review from FRidh as a code owner January 28, 2018 18:54

GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jan 28, 2018

GrahamcOfBorg reviewed Jan 28, 2018

View reviewed changes

dotlambda reviewed Jan 29, 2018

View reviewed changes

FRidh added 6.topic: python 2.status: work-in-progress labels Feb 3, 2018

mbode force-pushed the doitlive_3_0_3 branch from 5ceb7f6 to 180d604 Compare March 10, 2018 23:10

GrahamcOfBorg added 8.has: package (new) and removed 6.topic: python labels Mar 10, 2018

dotlambda requested changes Mar 14, 2018

View reviewed changes

mbode force-pushed the doitlive_3_0_3 branch from 180d604 to 0cf1643 Compare March 14, 2018 18:31

dotlambda reviewed Mar 14, 2018

View reviewed changes

doitlive: init at 3.0.3

2217c70

mbode force-pushed the doitlive_3_0_3 branch from 0cf1643 to 2217c70 Compare March 14, 2018 19:00

dotlambda approved these changes Mar 14, 2018

View reviewed changes

dotlambda merged commit 6d661f3 into NixOS:master Mar 14, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

doitlive: init at 3.0.3 #34361

doitlive: init at 3.0.3 #34361

mbode commented Jan 28, 2018 •

edited

fpletz commented Jan 28, 2018

fpletz commented Jan 28, 2018

GrahamcOfBorg left a comment

GrahamcOfBorg left a comment

GrahamcOfBorg left a comment

dotlambda Jan 29, 2018

dotlambda Jan 29, 2018

mbode Mar 10, 2018

dotlambda Mar 14, 2018

dotlambda Mar 14, 2018

mbode Mar 14, 2018

dotlambda Mar 14, 2018

mbode Mar 14, 2018

dotlambda Mar 14, 2018

mbode Mar 14, 2018

dotlambda Mar 14, 2018

mbode Mar 14, 2018

dotlambda Mar 14, 2018

dotlambda commented Mar 14, 2018

GrahamcOfBorg commented Mar 14, 2018

GrahamcOfBorg commented Mar 14, 2018


		propagatedBuildInputs = [ click ];

		checkInputs = [ ipython ];

		@@ -20134,6 +20134,8 @@ with pkgs;

		dbus-map = callPackage ../tools/misc/dbus-map { };

		doitlive = callPackage ../tools/misc/doitlive { };

doitlive: init at 3.0.3 #34361

doitlive: init at 3.0.3 #34361

Conversation

mbode commented Jan 28, 2018 • edited

Motivation for this change

Things done

fpletz commented Jan 28, 2018

fpletz commented Jan 28, 2018

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dotlambda commented Mar 14, 2018

GrahamcOfBorg commented Mar 14, 2018

GrahamcOfBorg commented Mar 14, 2018

mbode commented Jan 28, 2018 •

edited