Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wildmidi: 0.3.9 -> 0.4.2 #33891

Merged
merged 1 commit into from Feb 8, 2018
Merged

wildmidi: 0.3.9 -> 0.4.2 #33891

merged 1 commit into from Feb 8, 2018

Conversation

bjornfor
Copy link
Contributor

Motivation for this change

0.4.2 fixes the following CVEs:
CVE-2017-11661
CVE-2017-11662
CVE-2017-11663
CVE-2017-11664

Fixes #33877.

Untested! Also, I'm not sure if this can be backported to release-17.09 due to 0.4.0 seemingly having breaking changes. https://github.com/Mindwerks/wildmidi/releases

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@vcunat
Copy link
Member

vcunat commented Feb 3, 2018

DoS in wildmidi – that doesn't sound like anything "important", so I suppose we can omit 17.09.

vcunat added a commit that referenced this pull request Feb 3, 2018
@vcunat
Merge #33891: wildmidi: 0.3.9 -> 0.4.2
e2a0965 
Fixes DoS CVEs.  qmmp build failed before this merge (the same way).
@vcunat
Copy link
Member

vcunat commented Feb 3, 2018

Staged.

@bjornfor
Copy link
Contributor Author

bjornfor commented Feb 3, 2018

Thanks!

@FRidh FRidh merged commit b13230c into NixOS:master Feb 8, 2018
@bjornfor bjornfor deleted the wildmidi-update branch February 8, 2018 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wildmidi: Outdated & open issues (CVE-2017-11661, CVE-2017-11662, CVE-2017-11663, CVE-2017-11664)
4 participants
@bjornfor @vcunat @FRidh @GrahamcOfBorg