Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bettercap: init at 1.6.2 #33902

Merged
merged 2 commits into from Jan 16, 2018
Merged

bettercap: init at 1.6.2 #33902

merged 2 commits into from Jan 16, 2018

Conversation

y0no
Copy link

@y0no y0no commented Jan 15, 2018 •
edited

Motivation for this change

This package was missing

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@y0no y0no changed the title bettercap: init at 1.6.2 WIP: bettercap: init at 1.6.2 Jan 15, 2018
@Mic92
Copy link
Member

Mic92 commented Jan 15, 2018 •
edited

when you are finished, please also name your commit: bettercap: init at 1.6.2

@y0no y0no changed the title WIP: bettercap: init at 1.6.2 bettercap: init at 1.6.2 Jan 15, 2018
@y0no
Copy link
Author

y0no commented Jan 15, 2018

Seems good for me. Any advices ? This is my first package. 😄

@Mic92 Mic92 merged commit 7e04026 into NixOS:master Jan 16, 2018
@Mic92
Copy link
Member

Mic92 commented Jan 16, 2018

Looks good to me. Thanks!

@y0no y0no deleted the add_bettercap branch January 26, 2018 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@y0no @Mic92 @GrahamcOfBorg @Janik-Haag