New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid package attributes starting with a digit #33897
Conversation
I like the intention, but don't like the |
What do you propose? I went with an underscore because there are already two packages doing this in nixpkgs. |
Please also add renamed packages to |
I wonder what's the precedent, in major packaging systems. Have you looked? Nitpick: you forgot |
Not yet, I will research a bit.
Ah, right. I forgot to link it: 2048-in-terminal is addressed in #33846 |
Other package managers do not avoid names starting with digits: It seems that this issue is better addressed in Nix rather than in Nixpkgs: |
Hmm, changing nix for this is an interesting option. Still, my eye might tend to parse "389-ds" as subtraction... |
The eye will adjust. Nix supports |
It would be quite an incompatible change. When I remember how the "x:x" change goes... |
I have checked that modifying the lexer to support IDs starting with an integer (and prioritizing INTs to IDs to disambiguate) does not affect parsing of any In 0b16704#r14008920 @edolstra said:
But e.g. |
@orivej I didn't consider changing Nix syntax. I'm not sure about it though. |
(however this gets resolved, please include 2048-in-terminal here as well, since it should be handled the same as others in this PR. Thanks!) |
Motivation for this change
See the release notes.
Things done
./result/bin/
)